Open
Conversation
* Quotes around $1 in the `die` and `warn` functions * Use `tput` instead of hardcoded escape sequence
Invoking the install script with NOBACKUP=1 now will skip the backup step.
+ If tput doesn't exist + If tput emits error
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Two issues with the current
install.shfor Linux:dieandwarnfunctions chop the string to only its first wordmvresults in failure if the installation directory is mounted on a separate filesystem.This PR provides 2 things:
Related Issues
No related issue that I know of.
Checklist
Please ensure the following before requesting review:
Additional Notes
Skipping of backup process is done like so:
or if installing using
sudo: