Introduce VHACD based convex decomposition#253
Merged
Conversation
RyeMutt
force-pushed
the
rye/convexdecomp
branch
from
b6355d6 to
0f2ac93
Compare
LiruMouse
approved these changes
Oct 4, 2025
Contributor
LiruMouse
left a comment
LiruMouse
left a comment
There was a problem hiding this comment.
Most of this looks good enough to me, I just have some small suggestions.
| return LLCD_OK; | ||
| } | ||
|
|
||
| LLCDResult LLConvexDecompositionVHACD::getMeshFromStage( int stage, int hull, LLCDMeshData* meshDataOut ) |
Contributor
There was a problem hiding this comment.
Both get*FromStage functions are identical, aside from the datatype, so you could add a template member function to condense the logic and just have each call the template, thereby maintaining the interface.
Comment on lines
+193
to
+211
| const U16* index_data = static_cast<const U16*>(data); | ||
| const int stride = index_stride_bytes / sizeof(U16); | ||
| for (int i = 0; i < num_indices; ++i) | ||
| { | ||
| indices.emplace_back(index_data[i * stride + 0], | ||
| index_data[i * stride + 1], | ||
| index_data[i * stride + 2]); | ||
| } | ||
| } | ||
| else | ||
| { | ||
| const U32* index_data = static_cast<const U32*>(data); | ||
| const int stride = index_stride_bytes / sizeof(U32); | ||
| for (int i = 0; i < num_indices; ++i) | ||
| { | ||
| indices.emplace_back(index_data[i * stride + 0], | ||
| index_data[i * stride + 1], | ||
| index_data[i * stride + 2]); | ||
| } |
Contributor
There was a problem hiding this comment.
These could be condensed into a local template function, or even a lambda
auto set_indices = [&]<typename T>(){
const T* index_data = static_cast<const T*>(data);
const int stride = index_stride_bytes / sizeof(T);
for (int i = 0; i < num_indices; ++i)
{
indices.emplace_back(index_data[i * stride + 0],
index_data[i * stride + 1],
index_data[i * stride + 2]);
}
};| { | ||
| clear(); | ||
|
|
||
| if (!meshIn || !meshIn->mVertexBase || (meshIn->mNumVertices < 3) || (meshIn->mVertexStrideBytes != 12 && meshIn->mVertexStrideBytes != 16)) |
Contributor
There was a problem hiding this comment.
This condition is the same as in the function above, a template function could share the logic.
Comment on lines
+4741
to
+4742
| LLUUID decomp_id = decomp->mMeshID; // Copy to avoid invalidation in below deletion | ||
| decomposition_map::iterator iter = mDecompositionMap.find(decomp_id); |
Contributor
There was a problem hiding this comment.
Does order matter? If it doesn't, you can do the erasure before deleting decomp, and then you don't need a copy.
Co-authored-by: Liru Færs <lirusaito@gmail.com>
Co-authored-by: Liru Færs <lirusaito@gmail.com>
Co-authored-by: Liru Færs <lirusaito@gmail.com>
Co-authored-by: Liru Færs <lirusaito@gmail.com>
…lchemy into rye/convexdecomp
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Introduces a convex decomposition solution based on the VHACD library
Related Issues
Issue Link:
Checklist
Please ensure the following before requesting review:
Additional Notes