This repository was archived by the owner on Feb 6, 2026. It is now read-only.
NEW: Solve the lamino-alignment problem#94
Draft
carterbox wants to merge 127 commits intoAdvancedPhotonSource:mainfrom
Draft
NEW: Solve the lamino-alignment problem#94carterbox wants to merge 127 commits intoAdvancedPhotonSource:mainfrom
carterbox wants to merge 127 commits intoAdvancedPhotonSource:mainfrom
Conversation
Because map_coordinates is not implemented for higher orders in CuPy.
In theory, this should improve runtimes for long-lived Lamino operators.
Make the CUDA scatter gather kernels for the Lamino operator work for any number of dimensions because we will reuse it for the Tomo operator.
Conflicts: src/tike/operators/cupy/flow.py src/tike/operators/cupy/lamino.py src/tike/operators/numpy/flow.py src/tike/operators/numpy/lamino.py tests/test_align.py
|
Hello @carterbox! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
Comment last updated at 2021-07-27 16:34:15 UTC |
Conflicts: src/tike/align/solvers/cross_correlation.py src/tike/operators/cupy/alignment.py src/tike/operators/cupy/gradient.py src/tike/ptycho/ptycho.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Provide a function for solving the lamino-alignment problem with ADMM.
Approach
Solve the laminography + alignment problem using the Laminography operators, Lanczos Interpolation operator, and Flow solver which wraps OpenCV's Farneback's method.
Also includes some changes to the ThreadPool and scatter/gather CUDA kernels which should be merged separately.
Pre-Merge Checklists
Submitter
yapfto format python code.Reviewer