Conversation
…nd made it so you can stop calculating hkl in the diffreaction image viewer
… hkl viewer not loading due to mismatched title and ui file location
…, refactored 3d viewer to work with new data structure
update: uv environment with torch and segment anything packages
add: temp file to read data immediatly after saving and save compress…
remove: tab files from dir rename: tab3d to workspace_3d
RSM Converter new
update: change log
feature: database creation that stores app settings and variables
fix: refresh button
add: 3d controls and add functionality
Scan View update & Workbench
add: scan monitor to launcher
REF previous commit
add: import hdf5
…being busy(thread affinity)
add: converter ui to launcher
add: Monitor to launcher
fix: hkl 3d to read from the HKL, CACHE OPTIONS, etc groups
add: settings module for interfacing both db or .toml file
pecomyint
left a comment
There was a problem hiding this comment.
-
hdf5plugin missing from environment.yml. (add that)
-
utils/hdf5_writer.py (line 55) hardcodes Path('~/hdf5/').expanduser(). This might not be desired for all users or deployment environments.
-
database/db.py uses sqlite:///dashpva.db. This creates the DB in the current working directory, which can vary depending on how the app is launched. (good to put that in back to DashPV)
-
utils/hdf5_loader.py writes to hdf5_loader_errors.txt and error_output.txt in the current working directory (good to put that in back to DashPV)
-
inconsistent logging - utils/metadata_converter.py uses the logging module and writes to a logs/ directory.
utils/hdf5_loader.py manually opens and writes to text files (error_output.txt). -
utils/hdf5_writer.py: The save_caches_to_h5 method contains duplicated logic for saving data. The code block for saving (lines 96-122) is nearly identical to the code block for the uncompressed fallback (lines 125-165) (simply the codes and avoid duplications!)
-
utils/hdf5_loader.py: The methods load_h5_to_2d and load_h5_images_2d contain only pass. If these are intended to be implemented later, they should raise NotImplementedError or log a warning rather than silently doing nothing. (Add warming or raise error please)
PR: Feature - Post Analysis Workbench and 3D Visualization Suite
Overview
This PR introduces the new Post Analysis Workbench, a significant expansion of the data inspection capabilities. It allows users to transition between 1D, 2D, and 3D perspectives of scanned data. Additionally, it provides a specialized 3D Analysis Suite for volumetric slicing and internal data inspection.
Key Features
Structural Changes (HDF5)
To support these tools, the saving mechanism now explicitly includes:
Notes for Reviewers
References