Added Documents viewer plugin id to load pdf/excel/csv etc. files

[hackesofice]

the Documents Viewer plugin/extension provides the view support for multiple types of documents like pdf, csv, xlsx, docs etc.. developed and maintained by user 1446 HACKESOFICE.

Problem

when user opens these files directly through file manager => open with Acode then Acode opens these files directly to the text editor, which is not useful as these files are binary files.

Reason

Acode at first ( startup ) loads only plugins which are listed in List / Arrary ( HEME_IDENTIFIERS ) then other plugins ( Documents viewer also ) are loaded after Successful app startup. so the file handlers are registering after file load and user see's only bytes as text.## Solution> Added The Documents Viewer plugin id ( Which is "documentsviewer" ) in HEME_IDENTIFIERS List / Array.

Expected Workflow / behavior

Clicks on Acode app => load all plugins with the id available in HEME_IDENTIFIERS ( Now Documents Viewer Also ) => then Load Files.

Why It'll Work

Because of Acode will now load the plugin ( if available ) at startup so all the file handlers will be registered before loading/opening the particular files.

[gemini-code-assist]

Summary of Changes

Hello @hackesofice, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a critical user experience issue where common document types like PDFs, CSVs, and Excel files were being opened as raw text within the application's text editor. The core change involves adjusting the plugin loading sequence to ensure the dedicated 'Documents Viewer' plugin is initialized at startup. This guarantees that the appropriate file handlers are active when these document types are accessed, enabling them to be viewed correctly rather than as unreadable binary data.

Highlights

• Plugin Loading Mechanism: The 'documentsviewer' plugin ID has been added to the THEME_IDENTIFIERS set in src/lib/loadPlugins.js. This modification ensures that the Documents Viewer plugin is loaded at application startup, rather than after the initial app load.
• Improved Document Handling: This change resolves an issue where various document types (e.g., PDF, CSV, XLSX) were incorrectly opened in the text editor. By loading the Documents Viewer plugin earlier, its file handlers are registered before files are opened, allowing these documents to be viewed correctly.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[greptile-apps]

Queued: Greptile will review this PR after it finishes indexing your repository.

[gemini-code-assist]

Code Review

This pull request aims to load the 'documentsviewer' plugin at startup by adding it to the THEME_IDENTIFIERS set. While this achieves the desired functional outcome, it introduces a code clarity and maintainability issue by placing a non-theme plugin identifier into a list explicitly named for themes. My review provides feedback on how to address this to make the code's intent clearer for future maintenance.

[gemini-code-assist]

Adding documentsviewer to THEME_IDENTIFIERS is semantically incorrect as this plugin is not a theme. This makes the code confusing and harder to maintain. The goal is to load this plugin at startup, and it seems THEME_IDENTIFIERS is being used for this purpose for other non-theme plugins as well (e.g., acode.plugin.extra_syntax_highlights), which points to a naming issue with the constant itself.

To improve code clarity, THEME_IDENTIFIERS should be renamed to something more generic, like STARTUP_PLUGIN_IDENTIFIERS. Consequently, the isThemePlugin function and its usages should also be renamed to reflect this broader purpose (e.g., isStartupPlugin). This will make the code's intent clear and improve long-term maintainability.