Update the show/hide example scripts to support PBR#61
Open
tapple wants to merge 7 commits intoAVsitter:develfrom
Open
Update the show/hide example scripts to support PBR#61tapple wants to merge 7 commits intoAVsitter:develfrom
tapple wants to merge 7 commits intoAVsitter:develfrom
Conversation
Member
|
Thanks @tapple for this addition. While the example scripts don't aim to cover every case I think your addition is worthwhile. Before we commit the PR I think we need to add a comment to each new line noting it's purpose, i.e. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
My artist friend asked me how to get your show/hide examples to work with PBR prims. I have made that update in my own script, but, never shared it. Here's a fix to your sample scripts. I also added these snippets to the lsl wiki: