This repository was archived by the owner on Feb 18, 2022. It is now read-only.
Active day indication when dateSetHidden is set#291
Open
vaggelanos wants to merge 2 commits into720kb:masterfrom
Open
Active day indication when dateSetHidden is set#291vaggelanos wants to merge 2 commits into720kb:masterfrom
vaggelanos wants to merge 2 commits into720kb:masterfrom
Conversation
|
Thanks for the changes, I applied them manually in my project and they fixed my problem with the dateSet. I see that the PR is from 28 Sep, is there some sort of problem ? |
Author
|
Waiting for 720kb to accept it ;/ |
|
Why is this not merged? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When dateSet is set and dateSetHidden , date is invalid since input is not set . Just added a simple check to set date to dateSet if date is NaN.