This repository was archived by the owner on Mar 25, 2025. It is now read-only.
fix: Check HTTPS_ENABLED env var before HTTPS redirection#7
Merged
Pazaz merged 13 commits into2004Scape:mainfrom Jan 11, 2025
Merged
fix: Check HTTPS_ENABLED env var before HTTPS redirection#7Pazaz merged 13 commits into2004Scape:mainfrom
Pazaz merged 13 commits into2004Scape:mainfrom
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
8 tasks
Pazaz
reviewed
Jan 10, 2025
…r, to website container
Contributor
Author
|
I added an extra file https://github.com/2004Scape/Website/pull/7/files#diff-51f6929abdfb9361c8f1466cd14634dbb7f67c2a8eb5de79aa8ff9e61c46df5a This doesn't change anything with how worlds work, its only to make docker production build easier (I'll add clear instructions for this in #1074) |
Contributor
|
Looks good. Note: world config will be moved to the database in one of the next feature updates so this may need to be touched on again then. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Uses HTTPS_ENABLED environment var for HTTPS redirection
Adds world config loader for docker
Users can now configure worlds directly from server repo, when running prod build
Environment variable is now passed to all 23 routes which use the header.ejs:
ᴄʟɪᴄᴋ ғᴏʀ ᴅᴇᴛᴀɪʟs
Why
For production build to work, these changes need to be made in the Website repository, as docker is pulling it from Server, see #1074