[Fix] Remove unnecessary const qualifier from pass-by-value parameters

[SYaoJun]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello @SYaoJun, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on minor code refactoring within the LRU.c file. It addresses a common C idiom by removing const qualifiers from function parameters that are passed by value. This change improves code clarity and adheres to best practices without altering the functional behavior of the cache eviction logic.

Highlights

• Code Cleanup: Removed the const qualifier from pass-by-value parameters in LRU_find (for update_cache) and LRU_remove (for obj_id) functions in LRU.c. This is a standard C practice as const on pass-by-value parameters is redundant.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request removes the const qualifier from pass-by-value scalar parameters in LRU.c. While this change is valid and can improve readability by reducing noise, it's applied inconsistently. The function signatures for LRU_find and LRU_remove now differ from their corresponding function pointer type definitions in cache.h. Furthermore, other functions within LRU.c (like LRU_init) and across the project still use const for pass-by-value parameters. For better code consistency and maintainability, it would be ideal to either expand the scope of this refactoring to be applied project-wide, including header files, or to revert this change if a broader refactoring is not intended at this time.

[1a1a11a]

Thank you! Can you update both the interface and the implementation?

[SYaoJun]

Thank you! Can you update both the interface and the implementation?

Of course. There are some other clang-tidy warnings, but I'm only focusing on the LRU cache for now. I can fix the other warnings next time.

[haochengxia]

Hi @SYaoJun, thanks for your efforts! Could you fix the left tiny quality issue via clang-format -i libCacheSim/include/libCacheSim/cache.h?

[SYaoJun]

Hi @SYaoJun, thanks for your efforts! Could you fix the left tiny quality issue via clang-format -i libCacheSim/include/libCacheSim/cache.h?

I've resolved this problem.