Fix 'BorderRadius?' can't be assigned to the parameter type 'BorderRadiusGeometry' error on 3.12.0-1.1.pre#6
Open
Foldblade wants to merge 3 commits into101Loop:masterfrom
Open
Fix 'BorderRadius?' can't be assigned to the parameter type 'BorderRadiusGeometry' error on 3.12.0-1.1.pre#6Foldblade wants to merge 3 commits into101Loop:masterfrom
Foldblade wants to merge 3 commits into101Loop:masterfrom
Conversation
- `flutter create example`, Flutter Channel beta, 3.12.0-1.1.pre - add windows, linux, macos, web directories
- `lib\skeleton_text.dart`, line 70 - In `pubspec.yaml`, `flutter: ">=3.12.0-0.0.pre"`
Contributor
|
This error now occurs when using the stable version of Flutter (3.13). |
Member
|
Can you resolve the conflict @Foldblade ? |
Author
|
@iamhssingh Hello, I've solve the conflict. Please take a look 😉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for your work and I really love this package!
I'm using Flutter Channel beta, 3.12.0-1.1.pre. The following error occured when I tried to run my project using
skeleton_text 3.0.0:To reproduce, just use the example in this package. (Since the example in this package was too old to run, so I re-generate the
exampledirectory to make it runable.)After a quick search, I found this Flutter PR: Fix nullability of ClipRRect.borderRadius, and it was merged since Flutter channel beta 3.12.0, commit 8fcb74d. So I simply deleted
as BorderRadius?inlib/skeleton_text.dartto make it work on 3.12.0-1.1.pre.Since it was fixed in Flutter 3.12.0 and this version is still in beta channel, so I also made a limitation,
flutter: ">=3.12.0-0.0.pre", inpubspec.yaml. SDK version number was set tosdk: ">=2.12.0 <4.0.0"to upgrade to Dart 3.x.Could you please check this PR and consider releasing a new version? Thanks!