-
-
Notifications
You must be signed in to change notification settings - Fork 969
Open
Description
Provide environment information
N/A - This affects the generated Dockerfile, not the local environment
Describe the bug
The trigger deploy command generates a Dockerfile that hardcodes npm i --no-audit --no-fund --no-save --no-package-lock on line 872 of packages/cli-v3/src/deploy/buildImage.ts, regardless of the project's actual package manager.
This breaks Yarn workspaces because:
- npm doesn't understand Yarn's
workspaces.nohoistconfiguration - npm doesn't support Yarn's selective resolutions
- npm installs packages in different locations than Yarn, breaking patch-package setups
Expected behavior: The CLI should detect the package manager from lockfiles (yarn.lock, pnpm-lock.yaml, package-lock.json) and use the appropriate install command:
yarn install --frozen-lockfilefor Yarnpnpm install --frozen-lockfilefor pnpmnpm cifor npm
Reproduction repo
n/a
To reproduce
- Create a Yarn monorepo with workspaces.nohoist in package.json
- Run
trigger deploy - Observe build failure with npm workspace errors, or packages installed in wrong locations
Additional information
No response
Metadata
Metadata
Assignees
Labels
No labels