diff --git a/src/app/components/elements/PageTitle.tsx b/src/app/components/elements/PageTitle.tsx index b042338f0c..4ec56fcbb4 100644 --- a/src/app/components/elements/PageTitle.tsx +++ b/src/app/components/elements/PageTitle.tsx @@ -65,7 +65,6 @@ export const PageTitle = ({ }: PageTitleProps) => { const dispatch = useAppDispatch(); const openModal = useAppSelector((state: AppState) => Boolean(state?.activeModals?.length)); - const user = useAppSelector((state: AppState) => state?.user); const headerRef = useRef(null); useEffect(() => { @@ -83,12 +82,12 @@ export const PageTitle = ({ // Extract nested ternary logic const renderHelpOrBoosterButton = () => { if (boosterVideoButton) { - const targetPath = user?.loggedIn - ? "/pages/booster_video_binary_conversion_and_addition" - : "/login?target=/pages/booster_video_binary_conversion_and_addition"; - return ( - ); diff --git a/src/app/components/navigation/IsaacApp.tsx b/src/app/components/navigation/IsaacApp.tsx index 270811015f..6f7f6705e9 100644 --- a/src/app/components/navigation/IsaacApp.tsx +++ b/src/app/components/navigation/IsaacApp.tsx @@ -179,11 +179,11 @@ export const IsaacApp = () => { {/* historic route which might get reintroduced with the introduction of dashboards */} - + - {(user && ifUser(user)) || isBot(userAgent) ? ( - - ) : user && !user.loggedIn && !isTutorOrAbove(user) && userNeedsToBeTutorOrTeacher ? ( - persistence.save(KEY.AFTER_AUTH_PATH, props.location.pathname + props.location.search) && ( - - ) - ) : user && !isTutorOrAbove(user) && userNeedsToBeTutorOrTeacher ? ( - - ) : user && user.loggedIn && !ifUser(user) ? ( - - ) : ( - persistence.save( - KEY.AFTER_AUTH_PATH, - props.location.pathname + props.location.search + props.location.hash, - ) && - )} - + { + if (ifUser(user) || isBot(userAgent)) { + return ( + + ); + } else if (!user.loggedIn && !isTutorOrAbove(user) && userNeedsToBeTutorOrTeacher) { + persistence.save(KEY.AFTER_AUTH_PATH, props.location.pathname + props.location.search); + return ; + } else if (!isTutorOrAbove(user) && userNeedsToBeTutorOrTeacher) { + return ; + } else if (user.loggedIn && !ifUser(user)) { + return ; + } else { + persistence.save( + KEY.AFTER_AUTH_PATH, + props.location.pathname + props.location.search + props.location.hash, + ); + return ; + } + }} + /> ); }} />