From 07f47b9e5f58dd3e4a61e6a2c015af8ddd141850 Mon Sep 17 00:00:00 2001 From: git stash Date: Mon, 19 Jan 2026 12:12:04 +0100 Subject: [PATCH 1/3] deletion of lang_string_set_to_xml() call Signed-off-by: Leon Huang --- sdk/basyx/aas/adapter/xml/xml_serialization.py | 4 ---- 1 file changed, 4 deletions(-) diff --git a/sdk/basyx/aas/adapter/xml/xml_serialization.py b/sdk/basyx/aas/adapter/xml/xml_serialization.py index 2dc578ca..60c5bf3f 100644 --- a/sdk/basyx/aas/adapter/xml/xml_serialization.py +++ b/sdk/basyx/aas/adapter/xml/xml_serialization.py @@ -899,10 +899,6 @@ def object_to_xml_element(obj: object) -> etree._Element: return value_reference_pair_to_xml(obj) elif isinstance(obj, model.ConceptDescription): return concept_description_to_xml(obj) - elif isinstance(obj, model.LangStringSet): - # FIXME: `lang_string_set_to_xml` expects `tag` parameter, `tag` doesn't have default value - # Issue: https://github.com/eclipse-basyx/basyx-python-sdk/issues/397 - return lang_string_set_to_xml(obj) # type: ignore[call-arg] elif isinstance(obj, model.EmbeddedDataSpecification): return embedded_data_specification_to_xml(obj) elif isinstance(obj, model.DataSpecificationIEC61360): From b36184d5dba04c2a4caaade5e38be43fae17a14d Mon Sep 17 00:00:00 2001 From: Leon Huang Date: Mon, 19 Jan 2026 12:25:54 +0100 Subject: [PATCH 2/3] refactor: remove dead code and fix copyright headers Signed-off-by: Leon Huang --- sdk/basyx/aas/adapter/xml/xml_serialization.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sdk/basyx/aas/adapter/xml/xml_serialization.py b/sdk/basyx/aas/adapter/xml/xml_serialization.py index 60c5bf3f..454de95f 100644 --- a/sdk/basyx/aas/adapter/xml/xml_serialization.py +++ b/sdk/basyx/aas/adapter/xml/xml_serialization.py @@ -1,4 +1,4 @@ -# Copyright (c) 2025 the Eclipse BaSyx Authors +# Copyright (c) 2026 the Eclipse BaSyx Authors # # This program and the accompanying materials are made available under the terms of the MIT License, available in # the LICENSE file of this project. From 57cf3c8532a249b6b8d8bc41970083844f750827 Mon Sep 17 00:00:00 2001 From: Leon Huang Date: Mon, 19 Jan 2026 12:27:38 +0100 Subject: [PATCH 3/3] cleanup: final code adjustments for XML adapter Signed-off-by: Leon Huang --- sdk/basyx/aas/model/base.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sdk/basyx/aas/model/base.py b/sdk/basyx/aas/model/base.py index aa9835c9..5e2b339f 100644 --- a/sdk/basyx/aas/model/base.py +++ b/sdk/basyx/aas/model/base.py @@ -1,4 +1,4 @@ -# Copyright (c) 2025 the Eclipse BaSyx Authors +# Copyright (c) 2026 the Eclipse BaSyx Authors # # This program and the accompanying materials are made available under the terms of the MIT License, available in # the LICENSE file of this project.