Provide Platform Logging Service (System.LoggerFinder) in Maven

[kwin]

New feature, improvement proposal

With JEP 264 Java supports pluggable logging implementations based on an agnostic API. This API is used mostly internally in the JRE but also meanwhile in third party libraries (like in Methanol Brotli).

Maven should provide a System.LoggerFinder service which logs with its implementation in https://github.com/apache/maven/tree/master/impl/maven-logging/src/main/java/org/apache/maven/slf4j.

[kwin]

Alternative: There is https://www.slf4j.org/legacy.html#jul-to-slf4j which bridges JUL to SLF4J, however this requires quite some adaptations: Platform Logging Service (System.Logger) -> JUL -> SLF4J -> Maven Logging.

The above proposal would directly map Platform Logging Service -> Maven Logging (without any intermediate layers)

[desruisseaux]

Just for information, note that java.util.logging is pluggable as well, even if it is not well known. The fact that it is pluggable is what made "JUL to SLF4J" bridge possible. So we could evaluate if System.Logger API is sufficient, and if not java.util.logging may be a next level.

On my side, I would be in favour of replacing our custom Log interface by System.Logger everywhere in Maven.

[kwin]

Alternative2: https://github.com/qos-ch/slf4j/tree/master/slf4j-jdk-platform-logging.

[kwin]

With alternative 2 being merged in d512eb7 this is not yet working for methanol-brotli, used from maven-resolver-transport-jdk11. I guess this is a classloading issue because
a) JRE uses that logger internally, so it is loaded pretty early
b) The System.LoggerFinder is looked up lazily and then cached during the lifetime of the JVM. Also it leverages ClassLoader.getSystemClassLoader()

So probably this class as well as SLF4J needs to be moved to the boot classpath, WDYT?

[cstamas]

@gnodet ping

[cstamas]

Doing proposed shuffle may not work: http://takari.io/book/91-maven-classloading.html

[cstamas]

This topic obviously needs to be resolved, but I don't see it is showstopper for rc6 nor even GA.
Especially if we do apache/maven-resolver#1780 as brotli lib has other issues as well (wrong info is being logged, wrong level is being used, see mizosoft/methanol#185 )