diff --git a/Restaurant/rasa_nlu/persistor.py b/Restaurant/rasa_nlu/persistor.py index 374621a..4bdc88f 100644 --- a/Restaurant/rasa_nlu/persistor.py +++ b/Restaurant/rasa_nlu/persistor.py @@ -130,7 +130,26 @@ def _decompress(compressed_path, target_path): # type: (Text, Text) -> None with tarfile.open(compressed_path, "r:gz") as tar: - tar.extractall( + def is_within_directory(directory, target): + + abs_directory = os.path.abspath(directory) + abs_target = os.path.abspath(target) + + prefix = os.path.commonprefix([abs_directory, abs_target]) + + return prefix == abs_directory + + def safe_extract(tar, path=".", members=None, *, numeric_owner=False): + + for member in tar.getmembers(): + member_path = os.path.join(path, member.name) + if not is_within_directory(path, member_path): + raise Exception("Attempted Path Traversal in Tar File") + + tar.extractall(path, members, numeric_owner=numeric_owner) + + + safe_extract(tar, target_path) target_path) # project dir will be created if it not exists