From f8de58aef48cc4e4c2994b6ef367b644cdf98f1a Mon Sep 17 00:00:00 2001 From: Alessandro Corbelli Date: Thu, 4 Oct 2018 16:11:18 +0200 Subject: [PATCH 1/4] Reset onlyUrl value to default after processing Fix #46 --- src/Minify.php | 1 + 1 file changed, 1 insertion(+) diff --git a/src/Minify.php b/src/Minify.php index 6cfb6c3..5fb83b1 100644 --- a/src/Minify.php +++ b/src/Minify.php @@ -166,6 +166,7 @@ private function process($file) { $this->provider->minify(); } + $this->onlyUrl = false; $this->fullUrl = false; } From c3d85891b1a51b5713d6a5a55183f73edd33d187 Mon Sep 17 00:00:00 2001 From: Alessandro Corbelli Date: Wed, 10 Oct 2018 10:26:28 +0200 Subject: [PATCH 2/4] Updated composer.json --- composer.json | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/composer.json b/composer.json index 32b4a98..6b9a09a 100644 --- a/composer.json +++ b/composer.json @@ -1,9 +1,13 @@ { - "name": "devfactory/minify", + "name": "guestisp/minify", "keywords": ["minify", "laravel5"], "description": "A package for minifying styles and javascript for laravel 5 ", "license": "MIT", "authors": [ + { + "name": "Da Costa Alcindo", + "email": "alcindo.dacosta@devfactory.ch" + }, { "name": "Da Costa Alcindo", "email": "alcindo.dacosta@devfactory.ch" From 4c4dfdfa137e8619858a10217a3c15a837689d16 Mon Sep 17 00:00:00 2001 From: Alessandro Corbelli Date: Mon, 15 Oct 2018 11:12:12 +0200 Subject: [PATCH 3/4] Add application/javascript as type attribute for javascripts --- src/Providers/JavaScript.php | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/Providers/JavaScript.php b/src/Providers/JavaScript.php index c90f51c..fe89713 100644 --- a/src/Providers/JavaScript.php +++ b/src/Providers/JavaScript.php @@ -27,7 +27,10 @@ public function minify() */ public function tag($file, array $attributes) { - $attributes = array('src' => $file) + $attributes; + $attributes = array( + 'type' => 'application/javascript', + 'src' => $file, + ) + $attributes; return "" . PHP_EOL; } From 57120aba66539a371a0fdf681fd96901fa20698e Mon Sep 17 00:00:00 2001 From: Alessandro Corbelli Date: Mon, 15 Oct 2018 11:13:38 +0200 Subject: [PATCH 4/4] Revert "Add application/javascript as type attribute for javascripts" This reverts commit 4c4dfdfa137e8619858a10217a3c15a837689d16. --- src/Providers/JavaScript.php | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/src/Providers/JavaScript.php b/src/Providers/JavaScript.php index fe89713..c90f51c 100644 --- a/src/Providers/JavaScript.php +++ b/src/Providers/JavaScript.php @@ -27,10 +27,7 @@ public function minify() */ public function tag($file, array $attributes) { - $attributes = array( - 'type' => 'application/javascript', - 'src' => $file, - ) + $attributes; + $attributes = array('src' => $file) + $attributes; return "" . PHP_EOL; }