-
Notifications
You must be signed in to change notification settings - Fork 10
Open
Description
Reporting some strange behaviour with Pyjibe when using the (extension) KVM model.
Issues:
- First, the calculation is slow, and gets progressively slower as Pyjibe goes through the folder after clicking "Apply Model and Fit All". However, going to a new folder speeds up again and the slowing down "starts again"
- After running "Apply Model and Fit All", the displayed
ratingsometimes changes when the user clicks on a single dataset in thefilelist.
Questions for understanding:
- Is the rating system deterministic?
- Is it correct that the ancillary parameter calculation get progressively slower as pyjibe runs through the files? Is this due to the curves needing the previous curve calculations because they are one dataset? Or is it just a bug?
- The ancillary parameters seems to bounce between very small values and the values they land on, presumably because they are being fit between an interval.
Possible reasons/solutions
I added caching to nanite/model/core/compute_ancillaries, which makes the calculation fast. However, max_indent ends up being nan which of course changes the expected ancillary param values. You even wrote a TODO note in this function for caching, but I am not yet familiar enough to implement it. Any ideas would be appreciated:
def compute_ancillaries(self, fd):
# TODO:
# - ancillaries are not cached yet (some ancillaries might depend on
# fitting interval or other initial parameters - take that into
# account)
# - "max_indent" actually belongs to "common_ancillaries" (see fit.py)"
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels